Re: [PATCH v4 1/4] rust: str: implement `PartialEq` for `BStr`

From: Gary Guo
Date: Wed Jan 15 2025 - 14:35:22 EST


On Thu, 09 Jan 2025 11:54:56 +0100
Andreas Hindborg <a.hindborg@xxxxxxxxxx> wrote:

> Implement `PartialEq` for `BStr` by comparing underlying byte slices.
>
> Reviewed-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
> Signed-off-by: Andreas Hindborg <a.hindborg@xxxxxxxxxx>

Reviewed-by: Gary Guo <gary@xxxxxxxxxxx>

> ---
> rust/kernel/str.rs | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/rust/kernel/str.rs b/rust/kernel/str.rs
> index d04c12a1426d1c1edeb88325bcd9c63bf45f9b60..c441acf76ebd1f14919b6d233edffbbbbf944619 100644
> --- a/rust/kernel/str.rs
> +++ b/rust/kernel/str.rs
> @@ -106,6 +106,12 @@ fn deref(&self) -> &Self::Target {
> }
> }
>
> +impl PartialEq for BStr {
> + fn eq(&self, other: &Self) -> bool {
> + self.deref().eq(other.deref())
> + }
> +}
> +
> /// Creates a new [`BStr`] from a string literal.
> ///
> /// `b_str!` converts the supplied string literal to byte string, so non-ASCII
>