Re: [PATCH v3 2/3] venus: pm_helpers: Use dev_pm_genpd_set_hwmode to switch GDSC mode on V4

[Bjorn Andersson]

On Wed, Jan 15, 2025 at 02:22:11PM -0600, Bjorn Andersson wrote:
> On Wed, Jan 15, 2025 at 12:02:31PM +0000, Bryan O'Donoghue wrote:
> > On 15/01/2025 09:30, Renjiang Han wrote:
> > > The POWER_CONTROL register addresses are not constant and can vary across
> > > the variants. Also as per the HW recommendation, the GDSC mode switching
> > > needs to be controlled from respective GDSC register and this is a uniform
> > > approach across all the targets. Hence use dev_pm_genpd_set_hwmode() API
> > > which controls GDSC mode switching using its respective GDSC register.
> > 
> > This paragraph is difficult to read and understand. Try something a bit more
> > like "Use dev_pm_genpd_set_hwmode() API to control GDSC mode switching. Do
> > that because of reason x, y z"
> 
> No, follow https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
> 
> It says "describe your problem, then describe your solution". "Use "
> isn't a good start of any problem description that I can think of.
> 

But just to clarify, I have no concern with your request for
improvements to the description of the problem being addressed. 

Regards,
Bjorn