Re: [PATCH v2 3/4] xen/cppc: get xen-required cppc perf caps data

[Jason Andryuk]

Hi Penny,

On 2024-12-05 00:42, Penny Zheng wrote:

> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
> index 13d6ff84a1e9..3a436591da07 100644
> --- a/drivers/acpi/cppc_acpi.c
> +++ b/drivers/acpi/cppc_acpi.c

> +	if (!high || !low || !nom || !min_nonlinear)
> +		pr_warn("CPPC: read zero cpc register value for Xen Processor %d"
> +			"highest_reg: %llu, lowest_reg: %llu"
> +			"nominal_reg: %llu, lowest_non_linear_reg: %llu\n",

The string lacks separation before highest and nominal and the preceding 
number.  Also, I think it could probably be consolidated to:

pr_warn("zero register for Xen CPU %d highest: %llu"
        " lowest: %llu nominal: %llu, non_linear: %llu\n,

pr_fmt is already "ACPI CPPC: ", and "_reg" doesn't add much value.

Regards,
Jason