[PATCH v5 00/15] powerpc/objtool: uaccess validation for PPC32 (v5)
From: Christophe Leroy
Date: Wed Jan 15 2025 - 17:52:00 EST
This series adds UACCESS validation for PPC32. It includes
a dozen of changes to objtool core.
It applies on top of series "Cleanup/Optimise KUAP (v3)"
https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=363368&state=*
It is almost mature, performs code analysis for all PPC32.
In this version objtool switch table lookup has been enhanced to
handle nested switch tables.
Most object files are correctly decoded, only a few
'unreachable instruction' warnings remain due to more complex
fonctions which include back and forth jumps or branches. Two types
of switch tables are missed at the time being:
- When switch table address is temporarily saved in the stack before
being used.
- When there are backwards jumps in the path.
It allowed to detect some UACCESS mess in a few files. They've been
fixed through other patches.
Changes in v5:
- Rebased on top of https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git branch tip/objtool/core
- Use generic annotation infrastructure to annotate uaccess begin and end instructions
Changes in v4:
- Split series in two parts, the powerpc uaccess rework is submitted
separately, see https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=363368&state=*
- Support of UACCESS on all PPC32 including book3s/32 which was missing in v3.
- More elaborated switch tables lookup.
- Patches 2, 7, 8, 9, 10, 11 are new
- Patch 11 in series v3 is now removed.
Changes in v3:
- Rebased on top of a merge of powerpc tree and tip/objtool/core tree
- Simplified support for relative switch tables based on relocation type
- Taken comments from Peter
Christophe Leroy (15):
objtool: Fix generic annotation infrastructure cross build
objtool: Move back misplaced comment
objtool: Allow an architecture to disable objtool on ASM files
objtool: Fix JUMP_ENTRY_SIZE for bi-arch like powerpc
objtool: Add INSN_RETURN_CONDITIONAL
objtool: Add support for relative switch tables
objtool: Merge mark_func_jump_tables() and add_func_jump_tables()
objtool: Track general purpose register used for switch table base
objtool: Find end of switch table directly
objtool: When looking for switch tables also follow conditional and
dynamic jumps
objtool: .rodata.cst{2/4/8/16} are not switch tables
objtool: Add support for more complex UACCESS control
objtool: Prepare noreturns.h for more architectures
powerpc/bug: Annotate reachable after warning trap
powerpc: Implement UACCESS validation on PPC32
arch/Kconfig | 5 +
arch/powerpc/Kconfig | 2 +
arch/powerpc/include/asm/book3s/32/kup.h | 2 +
arch/powerpc/include/asm/bug.h | 14 +-
arch/powerpc/include/asm/nohash/32/kup-8xx.h | 4 +-
arch/powerpc/include/asm/nohash/kup-booke.h | 4 +-
arch/powerpc/kexec/core_32.c | 4 +-
arch/powerpc/mm/nohash/kup.c | 2 +
include/linux/objtool.h | 3 +
include/linux/objtool_types.h | 2 +
scripts/Makefile.lib | 4 +
tools/include/linux/objtool_types.h | 2 +
tools/objtool/arch/powerpc/decode.c | 150 +++++++++++++++++-
.../arch/powerpc/include/arch/noreturns.h | 11 ++
.../arch/powerpc/include/arch/special.h | 11 +-
tools/objtool/arch/powerpc/special.c | 40 ++++-
.../objtool/arch/x86/include/arch/noreturns.h | 20 +++
tools/objtool/arch/x86/special.c | 8 +-
tools/objtool/check.c | 129 ++++++++++-----
tools/objtool/include/objtool/arch.h | 1 +
tools/objtool/include/objtool/check.h | 6 +-
tools/objtool/include/objtool/special.h | 3 +-
tools/objtool/noreturns.h | 14 +-
tools/objtool/special.c | 55 ++++---
24 files changed, 386 insertions(+), 110 deletions(-)
create mode 100644 tools/objtool/arch/powerpc/include/arch/noreturns.h
create mode 100644 tools/objtool/arch/x86/include/arch/noreturns.h
--
2.47.0