Re: [PATCH 04/35] drm/msm/dpu: drop INTF_SC7280_MASK

[Abhinav Kumar]

On 12/13/2024 2:14 PM, Dmitry Baryshkov wrote:
> The INTF_SC7280_MASK is equal to the INTF_SC7180_MASK. Stop defining a
> separate symbol and use the INTF_SC7180_MASK instead.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> ---
>   .../gpu/drm/msm/disp/dpu1/catalog/dpu_10_0_sm8650.h    |  8 ++++----
>   drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_7_0_sm8350.h |  8 ++++----
>   drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_7_2_sc7280.h |  6 +++---
>   .../gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h   | 18 +++++++++---------
>   drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_1_sm8450.h |  8 ++++----
>   .../gpu/drm/msm/disp/dpu1/catalog/dpu_8_4_sa8775p.h    | 16 ++++++++--------
>   drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_9_0_sm8550.h |  8 ++++----
>   .../gpu/drm/msm/disp/dpu1/catalog/dpu_9_2_x1e80100.h   | 18 +++++++++---------
>   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c         |  2 --
>   9 files changed, 45 insertions(+), 47 deletions(-)

I think when 781452286aeb ("drm/msm/dpu: drop DPU_INTF_DATA_COMPRESS 
from dpu catalog") was made, we had only two chipsets using those masks, 
sc7180 and sc7280, and since then all newer ones went with 
INTF_SC7280_MASK leading to this duplication.

We can drop this now,

Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>