Re: [PATCH] cpumask: Rephrase comments for cpu_any*() APIs
From: I Hsin Cheng
Date: Thu Jan 16 2025 - 03:14:52 EST
On Wed, Jan 15, 2025 at 10:55:13AM -0500, Yury Norov wrote:
> On Wed, Jan 15, 2025 at 08:55:50PM +0800, Kuan-Wei Chiu wrote:
> > On Wed, Jan 15, 2025 at 03:19:32PM +0800, I Hsin Cheng wrote:
> > > The cpu_any*() APIs comment states that it returns a "random" cpu within
> > > the given cpumask. Hoever it's not actually random as random itself
> >
> > s/Hoever/However
>
> Hi I Hsin,
>
> Can you please fix this typo, drop quotes around the 'arbitrary' word,
> as suggested by Mark, and send v2?
No problem, I'll fix it and send v2 asap.
>
> Please also keep Mark in the loop.
>
Sorry I must've missed to CC the patch to Mark, I'll recheck everyone's
email again.
Regards,
I Hsin
> Thanks,
> Yury
>
> >
> > > stands a meaning for uniform distribution.
> > >
> > > cpu_any*() APIs are a naming convention for the caller to states that it
> > > doesn't care which CPU it gets, so change "random" to "arbitrary" would
> > > be more appropriate.
> > >
> > > Signed-off-by: I Hsin Cheng <richard120310@xxxxxxxxx>
> >
> > With the above corrections:
> >
> > Reviewed-by: Kuan-Wei Chiu <visitorckw@xxxxxxxxx>
> >
> > Regards,
> > Kuan-Wei