Re: [PATCH net] net: dsa: microchip: ksz9477: fix multicast filtering

From: Arun.Ramadoss
Date: Thu Jan 16 2025 - 04:06:21 EST


Hi Tim,

> Hi Arun,
>
> Ok, that makes sense to me and falls in line with what my patch here
> was trying to do. When you enable the reserved multicast table it
> makes sense to update the entire table right? You are only updating
> one address/group. Can you please review and comment on my patch
> here?


During my testing of STP protocol, I found that Group 0 of reserved
multicast table needs to be updated. Since I have not worked on other
groups in the multicast table, I didn't update it.

I could not find the original patch to review, it shows "not found" in
lore.kernel.org.

Below are my comments,

- Why override bit is not set in REG_SW_ALU_VAL_B register.
- ksz9477_enable_stp_addr() can be renamed since it updates all the
table entries.




> Best Regards,
>
> Tim