Re: [PATCH v1] docs/arch: remove deprecated function name

From: Jiayuan Chen
Date: Thu Jan 16 2025 - 04:42:37 EST


On Tue, Jan 14, 2025 at 10:11:01AM +0800, Jonathan Corbet wrote:
> Jiayuan Chen <mrpre@xxxxxxx> writes:
>
> >
> > The question about the '?' preceding function names in an x86 stacktrace
> > keeps popping up, here's an indepth explanation. It helps if the reader
> > -stares at print_context_stack() and the whole machinery in and around
> > +stares at 'question mark' and the whole machinery in and around
> > arch/x86/kernel/dumpstack.c.
>
> Maybe - probably - I'm missing something, but I don't see how this is
> going to help our readers? If there *is* a function that will, by
> virtue of being stared at, help bring enlightenment, why wouldn't we
> name it?
>
> Thanks,
>
> jon
You're right.
As Randy mentioned, printk_stack_address() can probably be used as a
drop-in replacement for the original function, and I found that it hasn't
been touched since 3.12 anyway.