Re: [PATCH net 1/2] net: stmmac: Limit FIFO size by hardware feature value
From: Kunihiko Hayashi
Date: Thu Jan 16 2025 - 05:02:22 EST
Hi Furong,
Thank you for your comment.
On 2025/01/16 12:04, Furong Xu wrote:
On Thu, 16 Jan 2025 11:08:52 +0900, Kunihiko Hayashi
<hayashi.kunihiko@xxxxxxxxxxxxx> wrote:
Tx/Rx FIFO size is specified by the parameter "{tx,rx}-fifo-depth" from
the platform layer.
However, these values are constrained by upper limits determined by the
capabilities of each hardware feature. There is a risk that the upper
bits will be truncated due to the calculation, so it's appropriate to
limit them to the upper limit values.
Patch is fine, but the Fixes: tag is required here.
I see. I'll find original commit and send the patch with Fixes:
tag next.
And if you like to group this patch and the another patch into one series,
it is better to add a cover letter.
Yes, I omitted to add a cover letter.
However, this patch has no dependency on the other one and
needs some consideration, so I'll send it separately.
Thank you,
---
Best Regards
Kunihiko Hayashi