Re: [PATCH v3 3/6] usb: typec: ucsi: Add a macro definition for UCSI v1.0

From: Heikki Krogerus
Date: Thu Jan 16 2025 - 06:27:05 EST


On Tue, Jan 14, 2025 at 01:51:25AM +0800, Pengyu Luo wrote:
> Many platforms from Qualcomm(before X elite) still use UCSI v1.0,
> part of them hardcoded the version number to dsdt, add this for them.
>
> Signed-off-by: Pengyu Luo <mitltlatltl@xxxxxxxxx>

Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

> ---
> drivers/usb/typec/ucsi/ucsi.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h
> index 5ff369c24..82735eb34 100644
> --- a/drivers/usb/typec/ucsi/ucsi.h
> +++ b/drivers/usb/typec/ucsi/ucsi.h
> @@ -30,6 +30,7 @@ struct dentry;
> #define UCSIv2_MESSAGE_OUT 272
>
> /* UCSI versions */
> +#define UCSI_VERSION_1_0 0x0100
> #define UCSI_VERSION_1_1 0x0110
> #define UCSI_VERSION_1_2 0x0120
> #define UCSI_VERSION_2_0 0x0200
> --
> 2.47.1

--
heikki