Re: [PATCH v5 2/3] firmware: add Exynos ACPM protocol driver

[Tudor Ambarus]

On 12/31/24 2:32 PM, Tudor Ambarus wrote:
>>> +config EXYNOS_ACPM_PROTOCOL
>>> +	tristate "Exynos Alive Clock and Power Manager (ACPM) Message Protocol"
>>> +	depends on ARCH_EXYNOS || COMPILE_TEST
>>> +	depends on EXYNOS_MBOX
>> Is it build time dependency? No || COMPILE_TEST?
> There's no build time dependency, I'll drop this line.

There's no build time dependency on EXYNOS_MBOX, but there is on MAILBOX:

ERROR: modpost: "mbox_request_channel"
[drivers/firmware/samsung/acpm-protocol.ko] undefined!
ERROR: modpost: "mbox_free_channel"
[drivers/firmware/samsung/acpm-protocol.ko] undefined!
ERROR: modpost: "mbox_send_message"
[drivers/firmware/samsung/acpm-protocol.ko] undefined!
ERROR: modpost: "mbox_client_txdone"
[drivers/firmware/samsung/acpm-protocol.ko] undefined!

Will replace the line with "depends on MAILBOX".

Thanks!
ta