Re: [PATCH v1] serial: sc16is7xx: Extend IRQ check for negative valus

From: Andy Shevchenko
Date: Thu Jan 16 2025 - 07:02:11 EST


On Thu, Jan 16, 2025 at 11:02:23AM +0100, Jiri Slaby wrote:
> On 16. 01. 25, 10:53, Andy Shevchenko wrote:
> > On Thu, Jan 16, 2025 at 10:42:14AM +0100, Jiri Slaby wrote:
> > > This is threaded weirdly.
> >
> > Yeah, new patch (version) — new email thread.
> >
> > > On 16. 01. 25, 10:32, Andre Werner wrote:
> > > > Fix the IRQ check to treat the negative values as No IRQ.
> > >
> > > Care to describe on what HW that can happen?
> >
> > But how does this relevant? The whole idea is that neither I²C nor SPI
> > frameworks do not guarantee the IRQ field never be negative. This is
> > the fix to the previously submitted patch.
>
> They do AFAICS.

They don't AFAICT.

> Could you be more specific?

The documentation of the fields and their types suggests my way of perception.

--
With Best Regards,
Andy Shevchenko