Re: [PATCH net-next 3/3] net: phy: mediatek: add driver for built-in 2.5G ethernet PHY on MT7988

[Krzysztof Kozlowski]

On 16/01/2025 02:21, Sky Huang wrote:
> From: Sky Huang <skylake.huang@xxxxxxxxxxxx>
> 
> Add support for internal 2.5Gphy on MT7988. This driver will load
> necessary firmware and add appropriate time delay to make sure
> that firmware works stably. Also, certain control registers will
> be set to fix link-up issues.
> 
> Signed-off-by: Sky Huang <skylake.huang@xxxxxxxxxxxx>
> ---
>  MAINTAINERS                          |   1 +
>  drivers/net/phy/mediatek/Kconfig     |  11 +
>  drivers/net/phy/mediatek/Makefile    |   1 +
>  drivers/net/phy/mediatek/mtk-2p5ge.c | 343 +++++++++++++++++++++++++++
>  4 files changed, 356 insertions(+)
>  create mode 100644 drivers/net/phy/mediatek/mtk-2p5ge.c

I don't understand this. You already sent it half a year ago. You
received detailed review, but you now send again the same? Till we accept?

Doing same review twice is not acceptable. Ignoring the review either.

NAK.

Implement all the changes you were asked for, then send a next version
(v2) with proper, detailed, exhaustive changelog.

Best regards,
Krzysztof