Re: [PATCH v2 5/5] MIPS: mobileye: dts: eyeq6h: Enable cluster support
From: Jiaxun Yang
Date: Thu Jan 16 2025 - 09:14:51 EST
在2025年1月16日一月 下午12:39,Gregory CLEMENT写道:
> Hello Jiaxun,
[...]
>>> + coherency-manager {
>>> + compatible = "mti,eyeq6-cm";
>>
>> ^
>> Maybe compatible = "mti,eyeq6-cm", "mti,mips-cm";
>
> I explicitly makes the compatible "mti,eyeq6-cm" and "mti,mips-cm"
> mutually exclusive. This allows us to require the reg property only for
> "mti,mips-cm" and not have to provide it for "mti,eyeq6-cm".
IMO reg should also be optional for "mti,mips-cm". There is nothing special
for eyeq6 on address probing and so on.
Thanks
--
- Jiaxun