Re: [PATCH net-next] mptcp: fix for setting remote ipv4mapped address

[Matthieu Baerts]

Hi Jakub,

On 15/01/2025 22:21, Jakub Kicinski wrote:
> On Tue, 14 Jan 2025 19:06:22 +0100 Matthieu Baerts (NGI0) wrote:
>> From: Geliang Tang <tanggeliang@xxxxxxxxxx>
>>
>> Commit 1c670b39cec7 ("mptcp: change local addr type of subflow_destroy")
>> introduced a bug in mptcp_pm_nl_subflow_destroy_doit().
>>
>> ipv6_addr_set_v4mapped() should be called to set the remote ipv4 address
>> 'addr_r.addr.s_addr' to the remote ipv6 address 'addr_r.addr6', not
>> 'addr_l.addr.addr6', which is the local ipv6 address.
> 
> Wasn't there a syzbot report for this? Just curious.

Apparently no :)

>From what I understood, Geliang spotted that while looking at the code
around.

Thank you for having applied the patches!

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.