Re: [PATCH v1 1/1] PM: Revert "Add EXPORT macros for exporting PM functions"

[Greg Kroah-Hartman]

On Thu, Jan 16, 2025 at 05:21:51PM +0200, Andy Shevchenko wrote:
> The introduced macros are not doing what they intend for.
> Also there were no users of them for all this time.
> Drop them for good and to avoid possible misleading.
> 
> This reverts commit 41a337b40e983db4f0e1602308109f2b93687a06.
> 
> Reported-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>  include/linux/pm.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/include/linux/pm.h b/include/linux/pm.h
> index 08c37b83fea8..5dae93817141 100644
> --- a/include/linux/pm.h
> +++ b/include/linux/pm.h
> @@ -384,12 +384,8 @@ const struct dev_pm_ops name = { \
>  
>  #ifdef CONFIG_PM
>  #define _EXPORT_DEV_PM_OPS(name, license, ns)		_EXPORT_PM_OPS(name, license, ns)
> -#define EXPORT_PM_FN_GPL(name)				EXPORT_SYMBOL_GPL(name)
> -#define EXPORT_PM_FN_NS_GPL(name, ns)			EXPORT_SYMBOL_NS_GPL(name, "ns")
>  #else
>  #define _EXPORT_DEV_PM_OPS(name, license, ns)		_DISCARD_PM_OPS(name, license, ns)
> -#define EXPORT_PM_FN_GPL(name)
> -#define EXPORT_PM_FN_NS_GPL(name, ns)

Why not start using them instead?

thanks,

greg k-h