Re: [PATCH v1 1/1] PM: Revert "Add EXPORT macros for exporting PM functions"

[Greg Kroah-Hartman]

On Thu, Jan 16, 2025 at 05:32:23PM +0200, Andy Shevchenko wrote:
> On Thu, Jan 16, 2025 at 04:24:16PM +0100, Greg Kroah-Hartman wrote:
> > On Thu, Jan 16, 2025 at 05:21:51PM +0200, Andy Shevchenko wrote:
> 
> ...
> 
> > >  #ifdef CONFIG_PM
> > >  #define _EXPORT_DEV_PM_OPS(name, license, ns)		_EXPORT_PM_OPS(name, license, ns)
> > > -#define EXPORT_PM_FN_GPL(name)				EXPORT_SYMBOL_GPL(name)
> > > -#define EXPORT_PM_FN_NS_GPL(name, ns)			EXPORT_SYMBOL_NS_GPL(name, "ns")
> > >  #else
> > >  #define _EXPORT_DEV_PM_OPS(name, license, ns)		_DISCARD_PM_OPS(name, license, ns)
> > > -#define EXPORT_PM_FN_GPL(name)
> > > -#define EXPORT_PM_FN_NS_GPL(name, ns)
> > 
> > Why not start using them instead?
> 
> I tried and they didn't produce what we want (code elimination for
> the CONFIG_PM=n).

Ok, then please say that in the changelog text.

thanks,

greg k-h