Re: [PATCH v2 1/1] PM: Revert "Add EXPORT macros for exporting PM functions"

[Andy Shevchenko]

On Thu, Jan 16, 2025 at 05:09:29PM +0100, Rafael J. Wysocki wrote:
> On Thu, Jan 16, 2025 at 4:44 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> >
> > The introduced macros are not doing what they intend for, namely
> > they won't eliminate the code when CONFIG_PM=n.
> 
> I don't think they have ever been expected to eliminate the code then.
> They just don't export the symbols in that case.

Then I'm really puzzled with (potential) usefulness of them to begin with.
Having a dead code that is not exported is doubtful benefit.

> > Also there were no users of them for all this time.
> 
> This actually is a good argument for dropping stuff.
> 
> > Drop them for good and to avoid possible misleading.

-- 
With Best Regards,
Andy Shevchenko