Re: [PATCH] scsi: ufs: core: increase the NOP_OUT command timeout

[Bao D. Nguyen]

On 1/16/2025 1:59 AM, DooHyun Hwang wrote:
> > > It is found that is UFS device may take longer than 500ms(50ms *
> > > 10times) to respond to NOP_OUT command.
> > >
> > > The NOP_OUT command timeout was total 500ms that is from a timeout
> > > value of 50ms(defined by NOP_OUT_TIMEOUT) with 10 retries(defined by
> > > NOP_OUT_RETRIES)
> > >
> > > This change increase the NOP_OUT command timeout to total 1000ms by
> > > changing timeout value to 100ms(NOP_OUT_TIMEOUT)
> > >
> > > Signed-off-by: DooHyun Hwang <dh0421.hwang@xxxxxxxxxxx>
> > Why not edit hba->nop_out_timeout in the .init vop?
> > Like some vendors already do.
> >
> > Thanks,
> > Avri
> Thank you for your suggestion.
> I'll fix that in .init vop as you said.
>
> And I'll reject this patch.
Hi DooHyun Hwang,
Since this is a common issue that multiple platform vendors have to fix 
in their vops, should we fix it in the common code instead?

Reviewed-by: Bao D. Nguyen <quic_nguyenb@xxxxxxxxxxx>