Re: [PATCH net-next v04 1/1] hinic3: module initialization and tx/rx logic
From: Simon Horman
Date: Thu Jan 16 2025 - 13:10:51 EST
On Thu, Jan 16, 2025 at 09:51:53AM +0200, Gur Stavi wrote:
> From: gongfan <gongfan1@xxxxxxxxxx>
>
> This is [1/3] part of hinic3 Ethernet driver initial submission.
> With this patch hinic3 is a valid kernel module but non-functional
> driver.
>
> The driver parts contained in this patch:
> Module initialization.
> PCI driver registration but with empty id_table.
> Auxiliary driver registration.
> Net device_ops registration but open/stop are empty stubs.
> tx/rx logic.
>
> All major data structures of the driver are fully introduced with the
> code that uses them but without their initialization code that requires
> management interface with the hw.
>
> Submitted-by: Gur Stavi <gur.stavi@xxxxxxxxxx>
> Signed-off-by: Gur Stavi <gur.stavi@xxxxxxxxxx>
> Signed-off-by: Xin Guo <guoxin09@xxxxxxxxxx>
> Signed-off-by: gongfan <gongfan1@xxxxxxxxxx>
...
> diff --git a/Documentation/networking/device_drivers/ethernet/huawei/hinic3.rst b/Documentation/networking/device_drivers/ethernet/huawei/hinic3.rst
...
> +Completion Event Queue (CEQ)
> +--------------------------
nit: the length of the "---" line doesn't match that of the line above it.
...