Re: [PATCH 1/1] tools: add VM_WARN_ON_VMG definition

[Lorenzo Stoakes]

Andrew - is it possible to grab this for the 6.14 merge window? As is a
benign fix to VMA tests.

Thanks!

On Thu, Jan 16, 2025 at 10:15:38AM -0800, Suren Baghdasaryan wrote:
> vma tests compilation yields the following error:
>
> vma.c:732:9: error: implicit declaration of function ‘VM_WARN_ON_VMG’
>
> Fix it by adding missing VM_WARN_ON_VMG() definition.

Oh damn, super ironic I broke my own tests with my change... ugh! Mea
culpa. Thanks for fixing this!

>
> Fixes: e3a7ae85f87c ("mm/debug: prefer VM_WARN_ON_VMG() to report VMG debug warnings")
> Signed-off-by: Suren Baghdasaryan <surenb@xxxxxxxxxx>

Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx>

> Cc: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx>
> Cc: Liam R. Howlett <Liam.Howlett@xxxxxxxxxx>
> ---
> Applies over mm-unstable
>
>  tools/testing/vma/vma_internal.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/vma/vma_internal.h b/tools/testing/vma/vma_internal.h
> index 2404347fa2c7..1eae23039854 100644
> --- a/tools/testing/vma/vma_internal.h
> +++ b/tools/testing/vma/vma_internal.h
> @@ -38,6 +38,7 @@ extern unsigned long dac_mmap_min_addr;
>
>  #define VM_WARN_ON(_expr) (WARN_ON(_expr))
>  #define VM_WARN_ON_ONCE(_expr) (WARN_ON_ONCE(_expr))
> +#define VM_WARN_ON_VMG(_expr, _vmg) (WARN_ON(_expr))
>  #define VM_BUG_ON(_expr) (BUG_ON(_expr))
>  #define VM_BUG_ON_VMA(_expr, _vma) (BUG_ON(_expr))
>
>
> base-commit: 4637fa5d47a49c977116321cc575ea22215df22d
> --
> 2.48.0.rc2.279.g1de40edade-goog
>