Re: [PATCH] tracing: gfp: Fix the GFP enum values shown for user space tracing tools

[Steven Rostedt]

On Thu, 16 Jan 2025 13:23:59 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> +#define TRACE_DEFINE_GFP_FLAGS_GENERAL			\
> +	TRACE_DEFINE_ENUM(___GFP_DMA_BIT);		\
> +	TRACE_DEFINE_ENUM(___GFP_HIGHMEM_BIT);		\
> +	TRACE_DEFINE_ENUM(___GFP_DMA32_BIT);		\
> +	TRACE_DEFINE_ENUM(___GFP_MOVABLE_BIT);		\
> +	TRACE_DEFINE_ENUM(___GFP_RECLAIMABLE_BIT);	\
> +	TRACE_DEFINE_ENUM(___GFP_HIGH_BIT);		\
> +	TRACE_DEFINE_ENUM(___GFP_IO_BIT);		\
> +	TRACE_DEFINE_ENUM(___GFP_FS_BIT);		\
> +	TRACE_DEFINE_ENUM(___GFP_ZERO_BIT);		\
> +	TRACE_DEFINE_ENUM(___GFP_UNUSED_BIT);		\
> +	TRACE_DEFINE_ENUM(___GFP_DIRECT_RECLAIM_BIT);	\
> +	TRACE_DEFINE_ENUM(___GFP_KSWAPD_RECLAIM_BIT);	\
> +	TRACE_DEFINE_ENUM(___GFP_WRITE_BIT);		\
> +	TRACE_DEFINE_ENUM(___GFP_NOWARN_BIT);		\
> +	TRACE_DEFINE_ENUM(___GFP_RETRY_MAYFAIL_BIT);	\
> +	TRACE_DEFINE_ENUM(___GFP_NOFAIL_BIT);		\
> +	TRACE_DEFINE_ENUM(___GFP_NORETRY_BIT);		\
> +	TRACE_DEFINE_ENUM(___GFP_MEMALLOC_BIT);		\
> +	TRACE_DEFINE_ENUM(___GFP_COMP_BIT);		\
> +	TRACE_DEFINE_ENUM(___GFP_NOMEMALLOC_BIT);	\
> +	TRACE_DEFINE_ENUM(___GFP_HARDWALL_BIT);		\
> +	TRACE_DEFINE_ENUM(___GFP_THISNODE_BIT);		\
> +	TRACE_DEFINE_ENUM(___GFP_ACCOUNT_BIT);		\
> +	TRACE_DEFINE_ENUM(___GFP_ZEROTAGS_BIT);		\

> +	TRACE_DEFINE_ENUM(___GFP_LAST_BIT);

Hmm, I don't think I need to include the LAST_BIT.

> +
> +#ifdef CONFIG_KASAN_HW_TAGS
> +# define TRACE_DEFINE_GFP_FLAGS_KASAN			\
> +	TRACE_DEFINE_ENUM(___GFP_SKIP_ZERO_BIT);	\
> +	TRACE_DEFINE_ENUM(___GFP_SKIP_KASAN_BIT);
> +#else
> +# define TRACE_DEFINE_GFP_FLAGS_KASAN
> +#endif
> +#ifdef CONFIG_LOCKDEP
> +# define TRACE_DEFINE_GFP_FLAGS_LOCKDEP			\
> +	TRACE_DEFINE_ENUM(___GFP_NOLOCKDEP_BIT);
> +#else
> +# define TRACE_DEFINE_GFP_FLAGS_LOCKDEP
> +#endif

I also missed adding CONFIG_SLAB_OBJ_EXT.

I'll send a v2 shortly.

-- Steve

> +
> +#define TRACE_DEFINE_GFP_FLAGS			\
> +	TRACE_DEFINE_GFP_FLAGS_GENERAL		\
> +	TRACE_DEFINE_GFP_FLAGS_KASAN		\
> +	TRACE_DEFINE_GFP_FLAGS_LOCKDEP
> +
>  /*