Re: [PATCH v3 RESEND] net: mii: Fix the Speed display when the network cable is not connected

[Andrew Lunn]

On Wed, Jan 15, 2025 at 07:21:57PM +0800, Xiangqian Zhang wrote:
> Two different models of usb card, the drivers are r8152 and asix. If no
> network cable is connected, Speed = 10Mb/s. This problem is repeated in
> linux 3.10, 4.19, and 5.4. Both drivers call
> mii_ethtool_get_link_ksettings, but the value of cmd->base.speed in this
> function can only be SPEED_1000 or SPEED_100 or SPEED_10.
> When the network cable is not connected, set cmd->base.speed
> =SPEED_UNKNOWN.
> 
> v2:
> https://lore.kernel.org/20250111132242.3327654-1-zhangxiangqian@xxxxxxxxxx
> 
> Signed-off-by: Xiangqian Zhang <zhangxiangqian@xxxxxxxxxx>

You say this problem occurs in some older kernels, so ideally we want
this patch backported. Please could you add a Fixes: tag for when the
problem first appeared.

Please also read at least section 1.4 of:

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

    Andrew

---
pw-bot: cr