Re: [PATCH 10/12] dt-bindings: phy: allwinner: add v853 usb phy

[András Szemző]

> On 15 Jan 2025, at 08:51, Vinod Koul <vkoul@xxxxxxxxxx> wrote:
> 
> On 10-01-25, 13:39, Andras Szemzo wrote:
>> Document Allwinner v853 USB phy.
>> 
>> Signed-off-by: Andras Szemzo <szemzo.andras@xxxxxxxxx>
>> ---
>> .../phy/allwinner,sun8i-v853-usb-phy.yaml     | 89 +++++++++++++++++++
>> 1 file changed, 89 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/phy/allwinner,sun8i-v853-usb-phy.yaml
>> 
>> diff --git a/Documentation/devicetree/bindings/phy/allwinner,sun8i-v853-usb-phy.yaml b/Documentation/devicetree/bindings/phy/allwinner,sun8i-v853-usb-phy.yaml
>> new file mode 100644
>> index 000000000000..773c3f476db8
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/phy/allwinner,sun8i-v853-usb-phy.yaml
>> @@ -0,0 +1,89 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/phy/allwinner,sun8i-v853-usb-phy.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Allwinner V853 USB PHY
>> +
>> +maintainers:
>> +  - Chen-Yu Tsai <wens@xxxxxxxx>
>> +  - Maxime Ripard <mripard@xxxxxxxxxx>
>> +
>> +properties:
>> +  "#phy-cells":
>> +    const: 1
>> +
>> +  compatible:
>> +    const:
>> +	- allwinner,sun8i-v853-usb-phy
> 
> Does this really need a new binding document, if so why... Cant this be
> added to one of the existing docs which driver uses?
> 

Yes, that was my first intention too, but didn’t know how to do it propery, but I’ll remove it
and add to one of the existing doc.

> -- 
> ~Vinod