Re: [PATCH 3/4] scsi: ufs: qcom: fix dev reference leaked through of_qcom_ice_get

From: Krzysztof Kozlowski
Date: Fri Jan 17 2025 - 02:44:28 EST


On 16/01/2025 15:49, Tudor Ambarus wrote:
> The driver leaks the device reference taken with
> of_find_device_by_node(). Fix the leak by using devm_of_qcom_ice_get().
>
> Fixes: 56541c7c4468 ("scsi: ufs: ufs-qcom: Switch to the new ICE API")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>
> ---
> drivers/ufs/host/ufs-qcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Your cover letter should mention the dependency on the first patch.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof