Re: [PATCH v1 1/1] gpio: tps65214: Add support for TI TPS65214 PMIC

From: Krzysztof Kozlowski
Date: Fri Jan 17 2025 - 04:27:59 EST


On 16/01/2025 23:38, Shree Ramamoorthy wrote:
> /*
> - * GPIO driver for TI TPS65215/TPS65219 PMICs
> + * TI TPS65214/TPS65215/TPS65219 PMIC GPIO Driver
> *
> * Copyright (C) 2024 Texas Instruments Incorporated - http://www.ti.com/
> */
> @@ -156,6 +156,10 @@ static const struct gpio_chip tps65219_template_chip = {
> };
>
> static const struct tps65219_chip_data chip_info_table[] = {
> + [TPS65214] = {
> + .ngpio = 2,
> + .offset = 1,


So that's the same as TPS65215? Why do you keep duplicating entries?

> + },
> [TPS65215] = {
> .ngpio = 2,
> .offset = 1,

Best regards,
Krzysztof