[PATCH net v9 0/4] Fix race conditions in ndo_get_stats64
From: Shinas Rasheed
Date: Fri Jan 17 2025 - 04:47:16 EST
Fix race conditions in ndo_get_stats64 by storing tx/rx stats
locally and not availing per queue resources which could be torn
down during interface stop. Also remove stats fetch from
firmware which is currently unnecessary
Changes:
V9:
- Iterate over OCTEP_MAX_QUEUES or OCTEP_VF_MAX_QUEUES in the
respective ndo_get_stats64() function, rather than just the active
queues.
- Update commit messages of 1/4 and 3/4 to reflect reordering.
V8: https://lore.kernel.org/all/20250116083825.2581885-1-srasheed@xxxxxxxxxxx/
- Reordered patches
V7: https://lore.kernel.org/all/20250114125124.2570660-1-srasheed@xxxxxxxxxxx/
- Updated octep_get_stats64() to be reentrant
V6: https://lore.kernel.org/all/20250110122730.2551863-1-srasheed@xxxxxxxxxxx/
- Corrected patch 2/4 which was not applying properly
V5: https://lore.kernel.org/all/20250109103221.2544467-1-srasheed@xxxxxxxxxxx/
- Store tx/rx stats locally and avail use stats in ndo_get_stats64()
instead of availing per queue resources there.
V4: https://lore.kernel.org/all/20250102112246.2494230-1-srasheed@xxxxxxxxxxx/
- Check if netdev is running, as decision for accessing resources
rather than availing lock implementations, in ndo_get_stats64()
V3: https://lore.kernel.org/all/20241218115111.2407958-1-srasheed@xxxxxxxxxxx/
- Added warn log that happened due to rcu_read_lock in commit message
V2: https://lore.kernel.org/all/20241216075842.2394606-1-srasheed@xxxxxxxxxxx/
- Changed sync mechanism to fix race conditions from using an atomic
set_bit ops to a much simpler synchronize_net()
V1: https://lore.kernel.org/all/20241203072130.2316913-1-srasheed@xxxxxxxxxxx/
Shinas Rasheed (4):
octeon_ep: remove firmware stats fetch in ndo_get_stats64
octeon_ep: update tx/rx stats locally for persistence
octeon_ep_vf: remove firmware stats fetch in ndo_get_stats64
octeon_ep_vf: update tx/rx stats locally for persistence
.../marvell/octeon_ep/octep_ethtool.c | 41 ++++++++-----------
.../ethernet/marvell/octeon_ep/octep_main.c | 29 ++++---------
.../ethernet/marvell/octeon_ep/octep_main.h | 6 +++
.../net/ethernet/marvell/octeon_ep/octep_rx.c | 11 ++---
.../net/ethernet/marvell/octeon_ep/octep_rx.h | 4 +-
.../net/ethernet/marvell/octeon_ep/octep_tx.c | 7 ++--
.../net/ethernet/marvell/octeon_ep/octep_tx.h | 4 +-
.../marvell/octeon_ep_vf/octep_vf_ethtool.c | 29 +++++--------
.../marvell/octeon_ep_vf/octep_vf_main.c | 25 ++++-------
.../marvell/octeon_ep_vf/octep_vf_main.h | 6 +++
.../marvell/octeon_ep_vf/octep_vf_rx.c | 9 ++--
.../marvell/octeon_ep_vf/octep_vf_rx.h | 2 +-
.../marvell/octeon_ep_vf/octep_vf_tx.c | 7 ++--
.../marvell/octeon_ep_vf/octep_vf_tx.h | 2 +-
14 files changed, 80 insertions(+), 102 deletions(-)
--
2.25.1