Re: [PATCH v2 1/1] PM: Revert "Add EXPORT macros for exporting PM functions"

From: Andy Shevchenko
Date: Fri Jan 17 2025 - 08:40:14 EST


On Thu, Jan 16, 2025 at 04:55:05PM +0000, Richard Fitzgerald wrote:
> On 16/01/2025 4:09 pm, Rafael J. Wysocki wrote:
> > On Thu, Jan 16, 2025 at 4:44 PM Andy Shevchenko
> > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > >
> > > The introduced macros are not doing what they intend for, namely
> > > they won't eliminate the code when CONFIG_PM=n.
> >
> > I don't think they have ever been expected to eliminate the code then.
> > They just don't export the symbols in that case.
> >
> > > Also there were no users of them for all this time.
>
> I had code changes to use them but they got lost at the bottom of a long
> backlog of other commits and have never been upstreamed. Removing these
> macros is fine with me.

I see, thanks for chiming in in both email threads!

> (apologies if you get this msg twice, there was a problem with email)

--
With Best Regards,
Andy Shevchenko