Re: [PATCH v3 3/3] vfio/nvgrace-gpu: Check the HBM training and C2C link status

From: Ankit Agrawal
Date: Fri Jan 17 2025 - 16:45:18 EST


>>
>> Ok, yeah. I tried to disable through setpci, and the probe is failing with ETIME.
>> Should we check if disabled and return -EIO for such situation to differentiate
>> from timeout?
>
> No, the driver needs to enable memory on the device around the iomap
> rather than assuming the initial state.  Thanks,
>
> Alex

Ack, thanks for the suggestion.

I'll change nvgrace_gpu_wait_device_ready to read the PCI_COMMAND
through pci_read_config_word before pci_iomap. And if PCI_COMMAND_MEMORY
is not set, update through pci_write_config_word.