Re: [PATCH 1/7] sched_ext: Implement event counter infrastructure and add an event

[Changwoo Min]

Hello,

Thank you for the suggestion, Andrea!

On 25. 1. 17. 18:49, Andrea Righi wrote:
> On Fri, Jan 17, 2025 at 12:15:37AM +0900, Changwoo Min wrote:
> ...
> > +/*
> > + * The event counter is organized by a per-CPU variable to minimize the
> > + * accounting overhead without synchronization. A system-wide view on the
> > + * event counter is constructed when requested by scx_bpf_get_event_stat().
> > + */
> > +static DEFINE_PER_CPU(struct scx_event_stat, event_stats);
>
> Should we consider tracking these statistics per-scheduler rather than
> globally (like adding scx_event_stat to sched_ext_ops)?
>
> It's not particularly important for now, but in the future, if we allow
> multiple scx schedulers to be loaded at the same time, tracking separate
> stats per-scheduler would be preferable.

It will be useful to get per-scheduler information. Since how the
scheduler composability will be embodied is wide open at this
point, I will revisit the interface design as the composability
design gets more concrete.

Regards,
Changwoo Min