Re: [PATCH net-next v2 11/15] mptcp: pm: add id parameter for get_addr

[Matthieu Baerts]

Hi Geliang,

On 18/01/2025 00:28, Geliang Tang wrote:
> Hi Matt,
> 
> On Fri, 2025-01-17 at 19:41 +0100, Matthieu Baerts (NGI0) wrote:
>> From: Geliang Tang <tanggeliang@xxxxxxxxxx>
>>
>> The address id is parsed both in mptcp_pm_nl_get_addr() and
>> mptcp_userspace_pm_get_addr(), this makes the code somewhat
>> repetitive.
>>
>> So this patch adds a new parameter 'id' for all get_addr()
>> interfaces.
>> The address id is only parsed in mptcp_pm_nl_get_addr_doit(), then
>> pass
>> it to both mptcp_pm_nl_get_addr() and mptcp_userspace_pm_get_addr().
>>
>> Signed-off-by: Geliang Tang <tanggeliang@xxxxxxxxxx>
>> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@xxxxxxxxxx>
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@xxxxxxxxxx>
>> ---
>> v2:
>> - Fix 'attr' no longer being set in mptcp_pm_nl_get_addr(), but still
>>   used in this patch (no longer in the next one). (Simon)
> 
> mptcp_userspace_pm_get_addr() needs to be updated too.

Arf, I didn't think about pm_userspace.c :(
I should have definitively squashed patch 11 and 12...

That's OK, I will resend them later, simply moving the line removal from
patch 11 to 12.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.