[RFC PATCH 2/3] phy: override dr_mode for phy0
From: Philippe Simons
Date: Sat Jan 18 2025 - 05:22:45 EST
PHY0 mode is fully determined by the selected mux route.
Ignore changes requests from controllers.
Signed-off-by: Philippe Simons <simons.philippe@xxxxxxxxx>
---
drivers/phy/allwinner/phy-sun4i-usb.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c b/drivers/phy/allwinner/phy-sun4i-usb.c
index 24fbabe7a..f163b355e 100644
--- a/drivers/phy/allwinner/phy-sun4i-usb.c
+++ b/drivers/phy/allwinner/phy-sun4i-usb.c
@@ -544,6 +544,18 @@ static int sun4i_usb_phy_set_mode(struct phy *_phy,
return -EINVAL;
}
+ if (data->cfg->phy0_dual_route) {
+ /*
+ For SoCs with dual route the PHY mode is fully determined by
+ the selected mux route (i.e. USB controller to use).
+ As both host (EHCI/OHCI) and peripheral (MUSB) controllers uses
+ the same PHY, both drivers can try to set PHY mode.
+ We need to ignore this requests, but not report error in case
+ of valid mode values.
+ */
+ return 0;
+ }
+
if (new_mode != data->dr_mode) {
dev_info(&_phy->dev, "Changing dr_mode to %d\n", new_mode);
data->dr_mode = new_mode;
--
2.47.1