Re: [PATCH v4 00/14] platform/x86: alienware-wmi driver rework

[Armin Wolf]

Am 17.01.25 um 09:13 schrieb Kurt Borja:

> Hello!
>
> I rebased these series on top of review-ilpo-next branch to pick up
> platform_profile latest changes.

So far i am quite pleased with the current state of the patch series. The issues
i found a relatively minor. I am already looking forward to reviewing the (hopefully
final) v5 patch series :).

Besides that: Did you test this changes on a real Alienware machine?

Thanks,
Armin Wolf

> ~ Kurt
> ---
> v3->v4:
>    - First 6 patches are already applied so they are not included
>
> [01/14]
>    - Reordered some lines in alienfx_probe() for aesthetic purposes
>
> [10/14]
>    - Removed pr_fmt from header file
>
> [11/14]
>    - Copy pr_fmt to each linked file
>
> v3: https://lore.kernel.org/platform-driver-x86/20250105153019.19206-2-kuurtb@xxxxxxxxx/
>
> Kurt Borja (14):
>    platform/x86: alienware-wmi: Add a state container for LED control
>      feature
>    platform/x86: alienware-wmi: Add WMI Drivers
>    platform/x86: alienware-wmi: Add a state container for thermal control
>      methods
>    platform/x86: alienware-wmi: Refactor LED control methods
>    platform/x86: alienware-wmi: Refactor hdmi, amplifier, deepslp methods
>    platform/x86: alienware-wmi: Refactor thermal control methods
>    platform/x86: alienware-wmi: Split DMI table
>    MAINTAINERS: Update ALIENWARE WMI DRIVER entry
>    platform/x86: Rename alienware-wmi.c
>    platform/x86: Add alienware-wmi.h
>    platform/x86: Split the alienware-wmi driver
>    platform/x86: dell: Modify Makefile alignment
>    platform/x86: Update alienware-wmi config entries
>    platform/x86: alienware-wmi: Update header and module information
>
>   MAINTAINERS                                   |    4 +-
>   drivers/platform/x86/dell/Kconfig             |   30 +-
>   drivers/platform/x86/dell/Makefile            |   45 +-
>   .../platform/x86/dell/alienware-wmi-base.c    |  488 +++++++
>   .../platform/x86/dell/alienware-wmi-legacy.c  |  100 ++
>   .../platform/x86/dell/alienware-wmi-wmax.c    |  773 +++++++++++
>   drivers/platform/x86/dell/alienware-wmi.c     | 1235 -----------------
>   drivers/platform/x86/dell/alienware-wmi.h     |  102 ++
>   8 files changed, 1515 insertions(+), 1262 deletions(-)
>   create mode 100644 drivers/platform/x86/dell/alienware-wmi-base.c
>   create mode 100644 drivers/platform/x86/dell/alienware-wmi-legacy.c
>   create mode 100644 drivers/platform/x86/dell/alienware-wmi-wmax.c
>   delete mode 100644 drivers/platform/x86/dell/alienware-wmi.c
>   create mode 100644 drivers/platform/x86/dell/alienware-wmi.h
>
>
> base-commit: 81e8e5017f5de3cf28004ae2b628629ef4d43635