Re: [PATCH rc] iommufd: Explicitize struct iommu_hwpt_pgfault padding
From: Nicolin Chen
Date: Mon Jan 20 2025 - 00:59:27 EST
On Mon, Jan 20, 2025 at 05:44:27AM +0000, Tian, Kevin wrote:
> > From: Nicolin Chen <nicolinc@xxxxxxxxxx>
> > Sent: Saturday, January 18, 2025 10:37 AM
> >
> > @@ -868,6 +868,7 @@ enum iommu_hwpt_pgfault_perm {
> > * @pasid: Process Address Space ID
> > * @grpid: Page Request Group Index
> > * @perm: Combination of enum iommu_hwpt_pgfault_perm
> > + * @__reserved: Must be 0.
>
> iommufd_fault_fops_read() doesn't follow this statement as
> hwpt_fault is on stack with that field uninitialized.
OK. I guess I should update the iommufd_fault_fops_read too.
Thanks
Nic