Re: [PATCH v3 1/5] dt-bindings: pinctrl: Add support for Amlogic SoCs

[Krzysztof Kozlowski]

On 20/01/2025 06:57, Xianwei Zhao wrote:
> Hi Krzysztof,
>     Thanks for reply.
> 
> On 2025/1/17 16:48, Krzysztof Kozlowski wrote:
>> [ EXTERNAL EMAIL ]
>>
>> On Wed, Jan 15, 2025 at 02:41:59PM +0800, Xianwei Zhao wrote:
>>> +properties:
>>> +  compatible:
>>> +    const: amlogic,pinctrl-a4
>>> +
>>> +  "#address-cells":
>>> +    const: 2
>>> +
>>> +  "#size-cells":
>>> +    const: 2
>>
>> Why this moved to '2'? 32-bit was not enough?
>>
> Previously only represented a register address offset value, now 
> directly represents a register, through 'ranges" which to represent. 
> 32-bit is enough, but since APB bus is defined as 64-bit, here is 

Changelog was silent on this.

> following. I increase support for 32-bit. Like the following values:

No, just keep one of these.



Best regards,
Krzysztof