Re: [PATCH v2 1/3] arm64: dts: rockchip: add overlay test for Edgeble NCM6A

[Quentin Schulz]

Hi Michael,

On 1/20/25 10:07 AM, Michael Riesch wrote:
> Hi Quentin,
>
> On 1/16/25 15:47, Quentin Schulz wrote:
> > From: Quentin Schulz <quentin.schulz@xxxxxxxxx>
> >
> > The Edgeble NCM6A can have WiFi modules connected and this is handled
> > via an overlay (commit 951d6aaa37fe ("arm64: dts: rockchip: Add Edgeble
> > NCM6A WiFi6 Overlay")).
> >
> > In order to make sure the overlay is still valid in the future, let's
> > add a validation test by applying the overlay on top of the main base
> > at build time.
> >
> > Fixes: 951d6aaa37fe ("arm64: dts: rockchip: Add Edgeble NCM6A WiFi6 Overlay")
> > Signed-off-by: Quentin Schulz <quentin.schulz@xxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/rockchip/Makefile | 6 +++++-
> >   1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> > index 86cc418a2255cdc22f1d503e9519d2d9572d4e9d..3f92d1a9d0b6efeee46ad4aff8c2b8ed3cb83d73 100644
> > --- a/arch/arm64/boot/dts/rockchip/Makefile
> > +++ b/arch/arm64/boot/dts/rockchip/Makefile
> > @@ -134,7 +134,6 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-armsom-w3.dtb
> >   dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-coolpi-cm5-evb.dtb
> >   dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-coolpi-cm5-genbook.dtb
> >   dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-io.dtb
> > -dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-wifi.dtbo
> >   dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6b-io.dtb
> >   dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-evb1-v10.dtb
> >   dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-friendlyelec-cm3588-nas.dtb
> > @@ -163,3 +162,8 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5.dtb
> >   dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5b.dtb
> >   dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5a.dtb
> >   dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5c.dtb
> > +
> > +# Overlays
> > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-wifi.dtb
> > +
>
> Maybe open a new section "# Compile time tests" or something like that?

The above line is to compile the build-time test of overlay application 
(notice the missing o in the extension). This points at the target below 
(which ends with -dtbs), which does require the dtbo to exist. So 
essentially, they are both for the build-time test of applying (and 
generating) DTBO. I feel like this comment/section would add to the 
confusion? I may have misunderstood what you are suggesting, can you 
provide an example?

Cheers,
Quentin