Re: [PATCH V2 02/23] ASoC: amd: acp70: add acp pci driver for ACP7.0 and ACP7.1 platforms

[Mukunda,Vijendar]

On 20/01/25 22:38, Mark Brown wrote:
> On Mon, Jan 20, 2025 at 03:31:09PM +0530, Vijendar Mukunda wrote:
>
>> This patch adds common PCI driver to bind to this device and get PCI
>> resources for ACP7.0 & ACP7.1 platforms.
>> +	ret = pci_request_regions(pci, "AMD ACP6.2 audio");
>> +	if (ret < 0) {
>> +		dev_err(&pci->dev, "pci_request_regions failed\n");
>> +		goto disable_pci;
>> +	}
> Looks like there's a cut'n'paste that needed to be updated here!  I'd
> suggest there might be some chance for code sharing, but I suspect the
> amount of code is so trivial that it's not really worth it.
Will update it. As platform specific changes exists along with
standard pci driver probe sequence, I don't think we really need to
go for common code here. Same time, We will improve code by
implementing common helper functions where ever it can be applicable.