Re: [PATCH] tracing: Fix #if CONFIG_MODULES to #ifdef CONFIG_MODULES

[Steven Rostedt]

On Mon, 20 Jan 2025 12:57:45 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> From: Steven Rostedt <rostedt@xxxxxxxxxxx>
> 
> A typo was introduced when adding the ":mod:" command that did
> a "#if CONFIG_MODULES" instead of a "#ifdef CONFIG_MODULES".
> Fix it.
> 
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202501110319.xY9ltUxL-lkp@xxxxxxxxx/

Cut and paste error. Wrong closes: Should have been:

  Closes: https://lore.kernel.org/oe-kbuild-all/202501190121.E2CIJuUj-lkp@xxxxxxxxx/

-- Steve


> Fixes: b355247df104e ("tracing: Cache ":mod:" events for modules not loaded yet")
> Signed-off-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>
> ---
>  kernel/trace/trace_events.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> index f762e554fad4..bb1406719c3f 100644
> --- a/kernel/trace/trace_events.c
> +++ b/kernel/trace/trace_events.c
> @@ -857,7 +857,7 @@ static int ftrace_event_enable_disable(struct trace_event_file *file,
>  	return __ftrace_event_enable_disable(file, enable, 0);
>  }
>  
> -#if CONFIG_MODULES
> +#ifdef CONFIG_MODULES
>  struct event_mod_load {
>  	struct list_head	list;
>  	char			*module;