Re: [PATCH net-next v0] net: mvpp2: Add parser configuration for DSA tags

[Aryan Srivastava]

Hi Maxime,

Thank you for your review.
On Thu, 2024-10-10 at 16:17 +0200, Maxime Chevallier wrote:
> ip link set ethX up => triggers a change in the DSA header size
> register
> 
> In that situation, the offset for the VLAN interface ethX.Y's header
> will be incorrect, if the DSA tag type gets updated at .open() time.
> 
> So I think a solution would be to replace the read from the
> MVPP2_MH_REG in the vlan filtering functions with a call your
> newly-introduced mvpp2_get_tag, making sure that we use the correct
> tag
> length for these parser entries as well.
> 
> Thanks,
Yes I agree this can be a potential issue, and I will update the patch
according to your suggestion above.
> 
> Maxime

Thanks, Aryan