RE: [PATCH v4 1/3] vfio/nvgrace-gpu: Read dvsec register to determine need for uncached resmem
From: Tian, Kevin
Date: Mon Jan 20 2025 - 20:21:07 EST
> From: Ankit Agrawal <ankita@xxxxxxxxxx>
> Sent: Tuesday, January 21, 2025 1:02 AM
> >>
> >> @@ -46,6 +51,7 @@ struct nvgrace_gpu_pci_core_device {
> >> struct mem_region resmem;
> >> /* Lock to control device memory kernel mapping */
> >> struct mutex remap_lock;
> >> + bool has_mig_hw_bug_fix;
> >
> > Is 'has_mig_hw_bug" clearer given GB+ hardware should all inherit
> > the fix anyway?
>
> IIUC, are you suggesting an inverted implementation? i.e. use
> has_mig_hw_bug as the struct member with the semantics
> !has_mig_hw_bug_fix?
yes