Re: [PATCH] net: davicom: fix UAF in dm9000_drv_remove

[Uwe Kleine-König]

Hello,

On Mon, Jan 20, 2025 at 04:25:57PM -0600, Chenyuan Yang wrote:
> dm is netdev private data and it cannot be
> used after free_netdev() call. Using adpt after free_netdev()

What is adpt?

> can cause UAF bug. Fix it by moving free_netdev() at the end of the
> function.

"can cause"? Doesn't that trigger reliable?

How did you find that issue? Did this actually trigger for you, or is it
a static checker that found it? Please mention that in the commit log.
 
> This is similar to the issue fixed in commit
> ad297cd2db8953e2202970e9504cab247b6c7cb4 ("net: qcom/emac: fix UAF in emac_remove").

Please shorten the commit id, typically to 12 chars as you did in the
Fixes line below.

> Fixes: cf9e60aa69ae ("net: davicom: Fix regulator not turned off on driver removal")
> Signed-off-by: Chenyuan Yang <chenyuan0y@xxxxxxxxx>

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature