Re: [PATCH v6 02/12] x86/mm: remove pv_ops.mmu.tlb_remove_table call

From: David Hildenbrand
Date: Tue Jan 21 2025 - 02:46:19 EST


On 21.01.25 02:03, Rik van Riel wrote:
On Mon, 2025-01-20 at 20:47 +0100, David Hildenbrand wrote:
On 20.01.25 03:40, Rik van Riel wrote:
Every pv_ops.mmu.tlb_remove_table call ends up calling
tlb_remove_table.


Indeed, but the !CONFIG_PARAVIRT variant paravirt_tlb_remove_table()
however calls tlb_remove_page().

Patch 1/12 from this series removes that.

After patch 1/12, we always call tlb_remove_table everywhere.

This patch contains the hunk:

-#ifndef CONFIG_PARAVIRT
-static inline
-void paravirt_tlb_remove_table(struct mmu_gather *tlb, void *table)
-{
- tlb_remove_page(tlb, table);
-}
-#endif
-

That is the source of my confusion.

--
Cheers,

David / dhildenb