RE: [PATCH v4] serial: sc16is7xx: Fix IRQ number check behavior
From: Maarten Brock
Date: Tue Jan 21 2025 - 05:26:45 EST
> From: Andre Werner <andre.werner@xxxxxxxxxxxxxxxxxxxxx>
>
> The logical meaning of the previous version is wrong due to a typo.
>
> If the IRQ equals 0, no interrupt pin is available and polling mode
> shall be used.
>
> Additionally, this fix adds a check for IRQ < 0 to increase robustness,
> because documentation still says that negative IRQ values cannot be
> absolutely ruled-out.
>
> Fixes: 104c1b9dde9d859dd01bd2d ("serial: sc16is7xx: Add polling mode if no IRQ
> pin is available")
>
> Signed-off-by: Andre Werner <andre.werner@xxxxxxxxxxxxxxxxxxxxx>
Reviewed-by: Maarten Brock <maarten.brock@xxxxxxxx>
Maarten