Re: [PATCH 1/7] ext4: convert EXT4_FLAGS_* defines to enum

[Jan Kara]

On Fri 17-01-25 16:23:09, libaokun@xxxxxxxxxxxxxxx wrote:
> From: Baokun Li <libaokun1@xxxxxxxxxx>
> 
> Do away with the defines and use an enum as it's cleaner.
> 
> Signed-off-by: Baokun Li <libaokun1@xxxxxxxxxx>

Yeah, why not. Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza

> ---
>  fs/ext4/ext4.h | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 4e7de7eaa374..612208527512 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -2232,9 +2232,11 @@ extern int ext4_feature_set_ok(struct super_block *sb, int readonly);
>  /*
>   * Superblock flags
>   */
> -#define EXT4_FLAGS_RESIZING	0
> -#define EXT4_FLAGS_SHUTDOWN	1
> -#define EXT4_FLAGS_BDEV_IS_DAX	2
> +enum {
> +	EXT4_FLAGS_RESIZING,	/* Avoid superblock update and resize race */
> +	EXT4_FLAGS_SHUTDOWN,	/* Prevent access to the file system */
> +	EXT4_FLAGS_BDEV_IS_DAX	/* Current block device support DAX */
			      ^^ we usually put comma here so that future
additions doesn't need to modify this line.

> +};
>  
>  static inline int ext4_forced_shutdown(struct super_block *sb)
>  {
> -- 
> 2.39.2
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR