Re: [PATCH 02/10] KVM: x86: Eliminate "handling" of impossible errors during SUSPEND

From: Paul Durrant
Date: Tue Jan 21 2025 - 11:03:49 EST


On 18/01/2025 00:55, Sean Christopherson wrote:
Drop KVM's handling of kvm_set_guest_paused() failure when reacting to a
SUSPEND notification, as kvm_set_guest_paused() only "fails" if the vCPU
isn't using kvmclock, and KVM's notifier callback pre-checks that kvmclock
is active. I.e. barring some bizarre edge case that shouldn't be treated
as an error in the first place, kvm_arch_suspend_notifier() can't fail.

Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>
---
arch/x86/kvm/x86.c | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)


Reviewed-by: Paul Durrant <paul@xxxxxxx>