Re: [PATCH v2 net] gro_cells: Avoid packet re-ordering for cloned skbs

[Eric Dumazet]

On Tue, Jan 21, 2025 at 12:50 PM Thomas Bogendoerfer
<tbogendoerfer@xxxxxxx> wrote:
>
> gro_cells_receive() passes a cloned skb directly up the stack and
> could cause re-ordering against segments still in GRO. To avoid
> this queue cloned skbs and use gro_normal_one() to pass it during
> normal NAPI work.
>
> Fixes: c9e6bc644e55 ("net: add gro_cells infrastructure")
> Suggested-by: Eric Dumazet <edumazet@xxxxxxxxxx>
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@xxxxxxx>
> --
> v2: don't use skb_copy(), but make decision how to pass cloned skbs in
>     napi poll function (suggested by Eric)
> v1: https://lore.kernel.org/lkml/20250109142724.29228-1-tbogendoerfer@xxxxxxx/
>

Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>

Thanks.