Re: [PATCH v2] i2c: iproc: Refactor prototype and remove redundant error checks

From: Uwe Kleine-König
Date: Tue Jan 21 2025 - 12:50:34 EST


Hello,

On Tue, Jan 21, 2025 at 04:48:18PM +0800, Wentao Liang wrote:
> The bcm_iproc_i2c_init() always returns 0. As a result, there
> is no need to check its return value or handle errors.
>
> This patch changes the prototype of bcm_iproc_i2c_init() to
> return void and removes the redundant error handling code after
> calls to bcm_iproc_i2c_init() in both the bcm_iproc_i2c_probe()
> and bcm_iproc_i2c_resume().
>
> Signed-off-by: Wentao Liang <vulab@xxxxxxxxxxx>

LGTM:

Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx>

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature