Re: [PATCH] net: stmmac: dwmac-loongson: Add fix_soc_reset function

[Qunqin Zhao]

在 2025/1/21 下午5:29, Huacai Chen 写道:
> Hi, Qunqin,
>
> The patch itself looks good to me, but something can be improved.
> 1. The title can be "net: stmmac: dwmac-loongson: Add fix_soc_reset() callback"
> 2. You lack a "." at the end of the commit message.
> 3. Add a "Cc: stable@xxxxxxxxxxxxxxx" because it is needed to backport
> to 6.12/6.13.
>
> After that you can add:
> Reviewed-by: Huacai Chen <chenhuacai@xxxxxxxxxxx>
OK, Thanks
> Huacai
>
> On Tue, Jan 21, 2025 at 4:26 PM Qunqin Zhao <zhaoqunqin@xxxxxxxxxxx> wrote:
> > Loongson's GMAC device takes nearly two seconds to complete DMA reset,
> > however, the default waiting time for reset is 200 milliseconds
> >
> > Signed-off-by: Qunqin Zhao <zhaoqunqin@xxxxxxxxxxx>
> > ---
> >   .../net/ethernet/stmicro/stmmac/dwmac-loongson.c    | 13 +++++++++++++
> >   1 file changed, 13 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
> > index bfe6e2d631bd..35639d26256c 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
> > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
> > @@ -516,6 +516,18 @@ static int loongson_dwmac_acpi_config(struct pci_dev *pdev,
> >          return 0;
> >   }
> >
> > +static int loongson_fix_soc_reset(void *priv, void __iomem *ioaddr)
> > +{
> > +       u32 value = readl(ioaddr + DMA_BUS_MODE);
> > +
> > +       value |= DMA_BUS_MODE_SFT_RESET;
> > +       writel(value, ioaddr + DMA_BUS_MODE);
> > +
> > +       return readl_poll_timeout(ioaddr + DMA_BUS_MODE, value,
> > +                                 !(value & DMA_BUS_MODE_SFT_RESET),
> > +                                 10000, 2000000);
> > +}
> > +
> >   static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> >   {
> >          struct plat_stmmacenet_data *plat;
> > @@ -566,6 +578,7 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
> >
> >          plat->bsp_priv = ld;
> >          plat->setup = loongson_dwmac_setup;
> > +       plat->fix_soc_reset = loongson_fix_soc_reset;
> >          ld->dev = &pdev->dev;
> >          ld->loongson_id = readl(res.addr + GMAC_VERSION) & 0xff;
> >
> >
> > base-commit: 5bc55a333a2f7316b58edc7573e8e893f7acb532
> > --
> > 2.43.0