Re: [PATCH] net: stmmac: dwmac-loongson: Add fix_soc_reset function

From: Huacai Chen
Date: Tue Jan 21 2025 - 23:09:48 EST


Hi, Jakub,

On Wed, Jan 22, 2025 at 2:11 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Tue, 21 Jan 2025 17:29:37 +0800 Huacai Chen wrote:
> > Hi, Qunqin,
> >
> > The patch itself looks good to me, but something can be improved.
> > 1. The title can be "net: stmmac: dwmac-loongson: Add fix_soc_reset() callback"
> > 2. You lack a "." at the end of the commit message.
> > 3. Add a "Cc: stable@xxxxxxxxxxxxxxx" because it is needed to backport
> > to 6.12/6.13.
>
> Please don't top post.
I know about inline replies, but in this case I agree with the code
itself so I cannot reply after the code.

Huacai