RE: [PATCH] usb: gadget: udc: renesas_usb3: Fix compiler warning
From: Yoshihiro Shimoda
Date: Tue Jan 21 2025 - 23:59:53 EST
Hello,
Thank you for the patch!
> From: guoren@xxxxxxxxxx, Sent: Wednesday, January 22, 2025 11:50 AM
>
> From: Guo Ren <guoren@xxxxxxxxxxxxxxxxx>
>
> drivers/usb/gadget/udc/renesas_usb3.c: In function 'renesas_usb3_probe':
> drivers/usb/gadget/udc/renesas_usb3.c:2638:73: warning: '%d'
> directive output may be truncated writing between 1 and 11 bytes into a
> region of size 6 [-Wformat-truncation=]
> 2638 | snprintf(usb3_ep->ep_name, sizeof(usb3_ep->ep_name), "ep%d", i);
> ^~~~~~~~~~~~~~~~~~~~~~~~ ^~ ^
Just a record. Since the maximum number of ep is up to 16, such an overflow
will not occur actually. Anyway, fixing this compiler warning is good.
> Fixes: 8292493c22c8 ("riscv: Kconfig.socs: Add ARCH_RENESAS kconfig option")
Please use the following Fixes tag:
Fixes: 746bfe63bba3 ("usb: gadget: renesas_usb3: add support for Renesas USB3.0 peripheral controller")
Best regards,
Yoshihiro Shimoda
> Cc: stable@xxxxxxxxxxxxxxx
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
<snip URL>
> Signed-off-by: Guo Ren <guoren@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Guo Ren <guoren@xxxxxxxxxx>
> ---
> drivers/usb/gadget/udc/renesas_usb3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c
> index fce5c41d9f29..89b304cf6d03 100644
> --- a/drivers/usb/gadget/udc/renesas_usb3.c
> +++ b/drivers/usb/gadget/udc/renesas_usb3.c
> @@ -310,7 +310,7 @@ struct renesas_usb3_request {
> struct list_head queue;
> };
>
> -#define USB3_EP_NAME_SIZE 8
> +#define USB3_EP_NAME_SIZE 16
> struct renesas_usb3_ep {
> struct usb_ep ep;
> struct renesas_usb3 *usb3;
> --
> 2.40.1
>